feat: CN 2 BN protocol communications #518
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fashion. Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
…on blockHash Verification using the signature of the blockProof instead of the prevHash of the next block and general improvements Signed-off-by: Alfredo Gutierrez <[email protected]>
…f directly sending items to the notifier Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
added
Block Node
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
… as is the first block on the blockNode, once the blockNode has its own state and configuration, it will have to start from that one. Signed-off-by: Alfredo Gutierrez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces support the following CN 2 BN communication scenarios:
Does not cover the following scenarios (pending):
5. When CN sends the expected block but BN already got it from somewhere else in a multi-stream environment.
6. When CN sends the expected block but BN fails Persistence (due to internal issues). / Internal Issues.
Related issue(s):
Fixes #519
Notes for reviewer:
This is a WIP, lacks UTs or actual UTs fixes (other than allowing them to compile)
Checklist