-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Loki to Dev Environment Stack #435
base: main
Are you sure you want to change the base?
Conversation
821eb8f
to
5aaf69a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One question: the pr title seems to imply that this will be present only for development. If that is so, how do we ensure that?
The changes done here are to integrate loki to the docker-compose stack, that deploy stack is used only on dev. there is a separate PR to integrate Loki on Production deployments using the included helm chart. |
…ing 2 handlers, coonsole and file. the file configuration keeps the logs local. Then another container prom-tail also has access to the shared volume where the block-node writes the logs. consumes them using tail on the same file. prom-tail pushes those logs to loki for transformation and storage. loki is added to Grafana as a loki type Datasource. Note: explore future iterations of logging using docker service, where promtail consumes the logs directly from stdout using the docker.sock service. Signed-off-by: Alfredo Gutierrez <[email protected]>
…m docker sock service Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
…g message. Signed-off-by: Alfredo Gutierrez <[email protected]>
326a2aa
to
7c6cf3c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
=========================================
Coverage 96.78% 96.78%
Complexity 409 409
=========================================
Files 82 82
Lines 1460 1460
Branches 90 90
=========================================
Hits 1413 1413
Misses 34 34
Partials 13 13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
Should license headers be present in all files? |
Description:
This allows the
Block-Node
developer, using the included docker-compose based Dev Env Stack to access the logs on the includedGrafana
dashboard.Also configures multiline log merging for promtail.
Related issue(s):
Fixes #432
Notes for reviewer:
BEFORE:
AFTER:
Checklist