Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add simulator image to publish artifacts CI #439

Merged
merged 6 commits into from
Jan 9, 2025
Merged

feat: Add simulator image to publish artifacts CI #439

merged 6 commits into from
Jan 9, 2025

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Dec 31, 2024 •
edited
Loading

Description:
Adds Simulator Docker image to the Publish CI

Related issue(s):

Fixes #437

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 changed the title Add simulator-image to publish artifacts CI feat: Add simulator image to publish artifacts CI Jan 2, 2025
@AlfredoG87 AlfredoG87 self-assigned this Jan 2, 2025
@AlfredoG87 AlfredoG87 added the Block Node Issues/PR related to the Block Node. label Jan 2, 2025
@AlfredoG87 AlfredoG87 added this to the 0.3.0 milestone Jan 2, 2025
@AlfredoG87 AlfredoG87 marked this pull request as ready for review January 2, 2025 03:08
@AlfredoG87 AlfredoG87 requested review from a team as code owners January 2, 2025 03:08
@AlfredoG87 AlfredoG87 added Simulator Issue related to Block Stream Simulator and removed Block Node Issues/PR related to the Block Node. labels Jan 2, 2025
ata-nas
ata-nas reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR needed? Changes here seem to already be present in #442.

.github/workflows/release-push-image.yaml Show resolved Hide resolved
mishomihov00
mishomihov00 previously approved these changes Jan 7, 2025
View reviewed changes
ata-nas
ata-nas previously approved these changes Jan 7, 2025
View reviewed changes
@AlfredoG87
Add simulator-image to publish artifacts CI
13d6256 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
fixing task name
8a82a6b 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
fixing postfix to right one
b774e66 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
fixing context to the one inside the build folder
43fb48f 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
improve tasks names
74b4fea 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
done automatically by IDE
0c99c83 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 dismissed stale reviews from ata-nas and mishomihov00 via 0c99c83 January 7, 2025 17:03
@AlfredoG87 AlfredoG87 force-pushed the publish-simulator-image branch from 9650f65 to 0c99c83 Compare January 7, 2025 17:03
@AlfredoG87 AlfredoG87 requested a review from a team as a code owner January 7, 2025 17:03
@AlfredoG87
Copy link
Contributor Author

@ata-nas @mishomihov00

I had to do a rebase due to licence header update that went in yesterday.
Please re-approve 🙏

ata-nas
ata-nas approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlfredoG87 AlfredoG87 merged commit 876ffef into main Jan 9, 2025
14 checks passed
@AlfredoG87 AlfredoG87 deleted the publish-simulator-image branch January 9, 2025 17:52
@AlfredoG87 AlfredoG87 added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Jan 17, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.78%. Comparing base (c303fa0) to head (0c99c83).
Report is 43 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main     #439   +/-   ##
=========================================
  Coverage     96.78%   96.78%           
  Complexity      409      409           
=========================================
  Files            82       82           
  Lines          1460     1460           
  Branches         90       90           
=========================================
  Hits           1413     1413           
  Misses           34       34           
  Partials         13       13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishomihov00 mishomihov00 mishomihov00 approved these changes

@ata-nas ata-nas ata-nas approved these changes

@dalvizu dalvizu Awaiting requested review from dalvizu dalvizu is a code owner automatically assigned from hashgraph/platform-ci

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner automatically assigned from hashgraph/release-engineering-managers

Assignees

@AlfredoG87 AlfredoG87

Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. Simulator Issue related to Block Stream Simulator
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Publish Docker Image for Simulator
3 participants
@AlfredoG87 @ata-nas @mishomihov00