chore: removed acme-cluster-issuer and haproxy-ingress #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: instamenta <[email protected]>
instamenta
requested review from
ericleponner,
svienot and
a team
as code owners
jeromy-cannon
approved these changes
Dec 19, 2024
Coverage Report
File CoverageNo changed files found. |
|
jeromy-cannon
deleted the
01570-chore-moved-acme-cluster-issuer-and-haproxy-ingress-to-solo-charts-cluster-setup
branch
nathanklick
reviewed
Dec 19, 2024
| @@ -75,20 +49,6 @@ image: | |||
| repository: hedera-registry/hedera-mirror-node-explorer | |||
| tag: "" # Defaults to the chart's app version | |||
|
|
|||
| ingress: | |||
There was a problem hiding this comment.
This should not have been removed. Please reinstate as it is required.
instamenta
restored the
01570-chore-moved-acme-cluster-issuer-and-haproxy-ingress-to-solo-charts-cluster-setup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removed
acme-cluster-issuerandhaproxy-ingressfrom dependencies since they are moved to thesolo-chartsrepositoryThis PR modifies
acme-cluster-issuerandhaproxy-ingressfrom dependenciesacme-cluster-issuerandhaproxy-ingressrelated values and templatesRelated issue: #1570