Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move network selector from TopNavBar to separate view NetworkSelector. #1578

Closed
wants to merge 1 commit into from

Conversation

ericleponner
Copy link
Collaborator

Description:

Change below add a new NetworkSelector view and move the network selector template/script from TopNavBar to it.

Related issue(s):

Fixes #1577

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.02% 24793 / 33491
🔵 Statements 74.02% 24793 / 33491
🔵 Functions 57.74% 947 / 1640
🔵 Branches 83.12% 4517 / 5434
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/page/NetworkSelector.vue 80.95% 100% 0% 80.95% 49, 52-54
src/components/page/TopNavBar.vue 97.22% 54.54% 0% 97.22% 1, 147, 149
Generated in workflow #1537

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@ericleponner
Copy link
Collaborator Author

After some reflection, we'll embed this change in UI revamp. Closing…

@ericleponner ericleponner deleted the network_selector branch December 24, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move network selector inlined code from TopNavBar to a separate vue
1 participant