-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update Java Module patching #15578
Conversation
c50c55f
to
ea4cf5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ea4cf5e
to
e9cb519
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15578 +/- ##
=============================================
- Coverage 58.14% 57.76% -0.39%
+ Complexity 21633 19526 -2107
=============================================
Files 2786 2674 -112
Lines 109604 98787 -10817
Branches 11215 10236 -979
=============================================
- Hits 63733 57066 -6667
+ Misses 41995 38119 -3876
+ Partials 3876 3602 -274 |
e9cb519
to
9d19998
Compare
9d19998
to
d9424e6
Compare
- Update extra-java-module-info to 1.9 - Configure a consistent classpath (new feature in 1.9) to no longer do multiple transformations of the same Jar - For the consistent/global classpath, use the 'gradle/aggregation' project to configure it (renamed from 'gradle/reports') - Update Guava and related libraries and remove no longer needed patch rules Signed-off-by: Jendrik Johannes <[email protected]>
d9424e6
to
b72c5be
Compare
Description:
This fixes the problem that many Jars are transformed several times, which leads to long IntelliJ import times and the Jars showing up many times in IntelliJ (which looks like this BEFORE this change):
Related issue(s):
#14255
Notes for reviewer:
Checklist