Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update Java Module patching #15578

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

jjohannes
Copy link
Collaborator

@jjohannes jjohannes commented Sep 22, 2024

Description:

  • Update extra-java-module-info to 1.9
  • Configure a consistent classpath (new feature in 1.9) to no longer do multiple transformations of the same Jar
  • For the consistent/global classpath, use the 'gradle/aggregation' project to configure it (renamed from 'gradle/reports')
  • Update Guava and related libraries and remove no longer needed patch rules

This fixes the problem that many Jars are transformed several times, which leads to long IntelliJ import times and the Jars showing up many times in IntelliJ (which looks like this BEFORE this change):

363586854-2f8e8fc3-ea3d-44d2-afe4-8a0121081af2

Related issue(s):

#14255

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jjohannes jjohannes added this to the v0.55 milestone Sep 22, 2024
@jjohannes jjohannes self-assigned this Sep 22, 2024
@jjohannes jjohannes marked this pull request as ready for review September 23, 2024 02:41
@jjohannes jjohannes requested review from a team as code owners September 23, 2024 02:41
@jjohannes jjohannes requested a review from a team September 23, 2024 02:41
@jjohannes jjohannes requested a review from a team as a code owner September 23, 2024 02:41
@jjohannes jjohannes force-pushed the 14255-jpms-patching-updates branch 2 times, most recently from c50c55f to ea4cf5e Compare September 26, 2024 16:54
rbarkerSL
rbarkerSL previously approved these changes Sep 26, 2024
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codacy-production bot commented Sep 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.30% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (debdc9a) 109421 67499 61.69%
Head commit (b72c5be) 98604 (-10817) 60530 (-6969) 61.39% (-0.30%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15578) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.76%. Comparing base (debdc9a) to head (b72c5be).
Report is 33 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #15578      +/-   ##
=============================================
- Coverage      58.14%   57.76%   -0.39%     
+ Complexity     21633    19526    -2107     
=============================================
  Files           2786     2674     -112     
  Lines         109604    98787   -10817     
  Branches       11215    10236     -979     
=============================================
- Hits           63733    57066    -6667     
+ Misses         41995    38119    -3876     
+ Partials        3876     3602     -274     

see 302 files with indirect coverage changes

Impacted file tree graph

@jjohannes jjohannes requested review from rbarkerSL and removed request for rbarkerSL September 26, 2024 23:52
@jjohannes jjohannes marked this pull request as draft September 29, 2024 13:38
@jjohannes jjohannes force-pushed the 14255-jpms-patching-updates branch from e9cb519 to 9d19998 Compare September 30, 2024 07:34
@jjohannes jjohannes marked this pull request as ready for review September 30, 2024 08:28
@jjohannes jjohannes requested a review from rbarkerSL September 30, 2024 08:28
@jjohannes jjohannes modified the milestones: v0.55, v0.56 Oct 1, 2024
@jjohannes jjohannes force-pushed the 14255-jpms-patching-updates branch from 9d19998 to d9424e6 Compare October 7, 2024 07:55
- Update extra-java-module-info to 1.9
- Configure a consistent classpath (new feature in 1.9) to no longer
  do multiple transformations of the same Jar
- For the consistent/global classpath, use the 'gradle/aggregation'
  project to configure it (renamed from 'gradle/reports')
- Update Guava and related libraries and remove no longer needed patch
  rules

Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes jjohannes force-pushed the 14255-jpms-patching-updates branch from d9424e6 to b72c5be Compare October 8, 2024 06:42
@jjohannes jjohannes merged commit 38a03e5 into develop Oct 16, 2024
50 checks passed
@jjohannes jjohannes deleted the 14255-jpms-patching-updates branch October 16, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants