Implement reload signal debouncing #1705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Just a note that we have been running this in production for the last 2-3 weeks and it has been performing well for us. |
komapa
requested review from
roncodingenthusiast
and removed request for
a team
|
@komapa is this still running in production, any issues you have noticed? This is looking good, do you also mind rebasing this before we approve/merge this? |
|
Hey @roncodingenthusiast, we ran this for more than a month in production and we did not see any issues. We eventually removed it because we were able to stop the reloads altogether and we did not want to keep having to apply the patch. I think it will be great to get this merged in if you think it looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is an implementation of debouncing reload signals so that only a single reload happens in the span of a single
splayperiod.I think the changes are pretty self-explanatory and the only thing that needed to change was starting
runner.Signal(s)in a go routine so that we can do all operations in parallel and not sequential.Please let me know if there is a better way to do this. Thank you!