Make setpgid configurable for exec commands #1848
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp#1494 added the setpgid setting to ensure signals are propagated to all processes and not just the subshell. However, this might not always be desirable. For instance, servers like uWSGI run workers in subprocesses and wait for workers to finish processing active requests for a while before restarting them to support graceful reloading. consul-template sending the reload signal to all processes, sends singals to these worker processes in uWSGI as well which can interfere with graceful reloads. Currently, we are working around this by using the array form of the command which does not set the pgid on the child process. But I feel it might be useful to make this option configurable as well.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1494 added the setpgid setting to ensure signals are propagated to all processes and not just the subshell. However, this might not always be desirable.
For instance, servers like uWSGI run workers in subprocesses and wait for workers to finish processing active requests for a while before restarting them to support graceful reloading. consul-template sending the reload signal to all processes, sends singals to these worker processes in uWSGI as well which can interfere with graceful reloads.
Currently, we are working around this by using the array form of the command which does not set the pgid on the child process. But I feel it might be useful to make this option configurable as well.
If the flag is unset, the existing behavior is retained.