Fixes Namespace Concat Bug for KV2 secrets #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyaac
force-pushed
the
Namespace_KV2_Concat_Bug
branch
from
3d06361
to
4a6cb66
Compare
VioletHynes
reviewed
May 6, 2024
VioletHynes
reviewed
May 6, 2024
| p := strings.TrimPrefix(rawPath, mountPath) | ||
|
|
||
| // Canonicalize the client namespace path to always having a '/' suffix | ||
| if !strings.HasSuffix(clientNamespace, "/") { |
There was a problem hiding this comment.
Out of scope for this PR, but maybe we should expose namespace.Canonicalize in our SDK for this kind of thing
There was a problem hiding this comment.
We can probably canonicalize it in Agent when we set the template config value
There was a problem hiding this comment.
Yeah, though I like keeping it in consul-template too for anything else that happens to be using it. Like I said, out of scope for this PR, but it seems like we have a need for external repos to be able to use the Canonicalize logic without repeating it. Food for thought!
VioletHynes
reviewed
May 6, 2024
VioletHynes
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing this first:
Vault-ent tests that test this new functionality: https://github.com/hashicorp/vault-enterprise/pull/5811 (Note, these will not pass in CI, until this pr is pushed a new consul-template version is used)
After pushing this PR: