Skip to content

Commit

Permalink
fixed super issue in hds modal body
Browse files Browse the repository at this point in the history
  • Loading branch information
zamoore committed Oct 21, 2024
1 parent de3cd84 commit e93a689
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
5 changes: 3 additions & 2 deletions .changeset/dull-lamps-retire.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"@hashicorp/design-system-components": minor
---

`Hds::DialogPrimitive::Description`
`Hds::DialogPrimitive::Body`
`Hds::DialogPrimitive::Description`
`Hds::DialogPrimitive::Body`
`Hds::Modal::Body`
- Fixed error caused by not passing the `args` argument from the constructor to `super`
7 changes: 5 additions & 2 deletions packages/components/src/components/hds/modal/body.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,18 @@ import Component from '@glimmer/component';
import { deprecate } from '@ember/debug';

export interface HdsModalBodySignature {
Args: {
contextualClass?: string;
};
Blocks: {
default: [];
};
Element: HTMLDivElement;
}

export default class HdsModalBody extends Component<HdsModalBodySignature> {
constructor(owner: unknown) {
super(owner, {});
constructor(owner: unknown, args: HdsModalBodySignature['Args']) {
super(owner, args);

deprecate(
'The `Hds::Modal::Body` sub-component is now deprecated and will be removed in the next major version of `@hashicorp/design-system-components`. Use `Hds::DialogPrimitive::Body` as one-to-one replacement.',
Expand Down

0 comments on commit e93a689

Please sign in to comment.