-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(showcase): speed up tests in CI #2176
base: main
Are you sure you want to change the base?
Conversation
You must have Developer access to commit code to HashiCorp on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
912aeed
to
490ca6a
Compare
3e6d3b4
to
0a03478
Compare
FWIW the percy message is not unique to this PR. I see it in others as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, using ember-exam
sounds like a good idea for introducing parallel testing.
I've only been able to compare test:ember
(not including the VRT testing in Percy) and the differences are marginal (2m12s, compared to 2m20s for main
); However, it could make all the difference on test:ember:percy
, but we seem to have some challenges around using Percy so not able to test that atm.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I tried adding On the other hand |
oh, good to know I thought |
Percy is fixed now so we could re-run the comparisons to see if the improvement in perf you were seeing was related to the introduction of ember-exam or a coincidence because percy tests were no longer running |
@Dhaulagiri I think I got it fixed so the tests aren't flaking anymore but but speed gains are a little less we are sitting at |
f69356a
to
572b9af
Compare
1a35b37
to
572b9af
Compare
@Dhaulagiri No worries at all. One thing I noticed that Percy is still in |
🤔
|
I was doing a a lot of manual starting/stopping of the tests to test this so that may be part of it, but we may also need to try following all the instructions here. |
no objections, any improvement is progress. I'll try and give this PR a fresh pair of eyes today or on Monday |
feat(showcase): speed up tests in CI
b632d4d
to
331ee6f
Compare
📌 Summary
This change cuts component tests in CI by 50%, today on average it takes around 4 minutes with this change we reduce it to 2 minutes.
The only potential issue I see is this message:
🛠️ Detailed description
📸 Screenshots
Before:
After:
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.