Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert - don't use role or aria-live for non-valid alert usages (HDS-3919) #2500

Merged
merged 8 commits into from
Oct 18, 2024
Merged

Alert - don't use role or aria-live for non-valid alert usages (HDS-3919) #2500

merged 8 commits into from
Oct 18, 2024

Commits on Oct 16, 2024

  1. HDS-3919 Add logic to role and aria-live to not use for non-alert alert

    @KristinLBradley
    KristinLBradley committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4c3a157 View commit details
    Browse the repository at this point in the history

  2. HDS-3919 Delete comment with question

    @KristinLBradley
    KristinLBradley committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c1714d1 View commit details
    Browse the repository at this point in the history

  3. HDS-3919 Override role and aria-live for Toast to always include, upd… 

    …ate and fix tests
    @KristinLBradley
    KristinLBradley committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    cca65f3 View commit details
    Browse the repository at this point in the history

  4. HDS-3919 add changset

    @KristinLBradley
    KristinLBradley committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5a4b061 View commit details
    Browse the repository at this point in the history

  5. HDS-3919 Update comments from feedback

    @KristinLBradley
    KristinLBradley committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b01b7df View commit details
    Browse the repository at this point in the history

  6. HDS-3919 Add clarifying comment

    @KristinLBradley
    KristinLBradley committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9b35f4a View commit details
    Browse the repository at this point in the history

  7. HDS-3919 rename variable

    @KristinLBradley
    KristinLBradley committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e0ba377 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Alert - Docs updates for informational alert usage (HDS-3918) (#2509) 

    Co-authored-by: Andrew Gendel <[email protected]>
Co-authored-by: Melanie Sumner <[email protected]>
Co-authored-by: Heather Larsen <[email protected]>
    @KristinLBradley @andgen404
    @MelSumner @heatherlarsen
    4 people authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    fc4bf78 View commit details
    Browse the repository at this point in the history