Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update Go to version 1.23.2 #985

Merged
merged 3 commits into from
Oct 17, 2024
Merged

build: update Go to version 1.23.2 #985

merged 3 commits into from
Oct 17, 2024

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Oct 17, 2024

related #984

commits have more relevant information if needed.

@jrasell jrasell self-assigned this Oct 17, 2024
@jrasell jrasell changed the title F go 1.23.2 build: update Go to version 1.23.2 Oct 17, 2024
jrasell added a commit that referenced this pull request Oct 17, 2024
@jrasell jrasell requested a review from a team October 17, 2024 08:04
@jrasell jrasell marked this pull request as ready for review October 17, 2024 08:04
The updated staticcheck application which is needed for go 1.23
seems to have broken multi-part config file loading. The file
within the plugins dir ignored a known warning about protobufs
which is now triggering. Adding a top level config again
surpresses it.
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrasell jrasell merged commit 1dc4dc9 into main Oct 17, 2024
33 checks passed
@jrasell jrasell deleted the f-go-1.23.2 branch October 17, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants