Default-sort variable keyvalues at serialization (#18051)

hashicorp · Jul 24, 2023 · 937d927 · 937d927
1 parent 55723e5
commit 937d927
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/.changelog/18051.txt b/.changelog/18051.txt
@@ -0,0 +1,3 @@
+```release-note:improvement
+ui: sort variable key/values alphabetically by key when editing
+```
diff --git a/ui/app/serializers/variable.js b/ui/app/serializers/variable.js
@@ -21,12 +21,14 @@ export default class VariableSerializer extends ApplicationSerializer {
     if (!hash.Items) {
       hash.Items = { '': '' };
     }
-    hash.KeyValues = Object.entries(hash.Items).map(([key, value]) => {
-      return {
-        key,
-        value,
-      };
-    });
+    hash.KeyValues = Object.entries(hash.Items)
+      .map(([key, value]) => {
+        return {
+          key,
+          value,
+        };
+      })
+      .sort((a, b) => a.key.localeCompare(b.key));
     delete hash.Items;
     return super.normalizeFindRecordResponse(
       store,