Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: use DNS instead of HTTP to get my_public_ipv4 #17759

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

gulducat
Copy link
Member

ipify.org is frequently flakey, causing Terraform apply/destroy to errors in E2E tests, e.g.

│ Error: HTTP request error. Response code: 502
│ 
Terraform planned the following actions, but then encountered a problem:
│   with data.http.my_public_ipv4,
│   on network.tf line 23, in data "http" "my_public_ipv4":
│   23: data "http" "my_public_ipv4" {

This replaces the HTTP lookup with DNS, which is faster (not that speed matters a whole lot here), but more importantly, OpenDNS should (hopefully) be more reliable.

Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gulducat gulducat merged commit 6bd5098 into main Jun 28, 2023
3 checks passed
@gulducat gulducat deleted the fix-e2e-my_public_ipv4 branch June 28, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants