Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [ui] Sort variables ascending by key at serialization time into release/1.6.x #18052

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #18051 to be assessed for backporting due to the inclusion of the label backport/1.6.x.

The below text is copied from the body of the original PR.


Doesn't impact the variable view page, as it's already using a table that sorts ascending on key by default, but on the edit page, which iterates over and creates a form label for each, they'll now appear ascending on key alpha.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/f-ui/variable-ordering-on-edit-page/incredibly-rich-lionfish branch from 3ba6bed to 41ea1e3 Compare July 24, 2023 20:00
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit ec76293 into release/1.6.x Jul 24, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/f-ui/variable-ordering-on-edit-page/incredibly-rich-lionfish branch from 62aa545 to 4467124 Compare July 24, 2023 20:00
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/f-ui/variable-ordering-on-edit-page/incredibly-rich-lionfish branch July 24, 2023 20:00
@github-actions
Copy link

Ember Test Audit comparison

release/1.6.x 4467124 change
passes 1498 1498 0
failures 1 1 0
flaky 0 0 0
duration 000ms 000ms -000ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants