metrics: introduce client config to include meta as part of the base label #23964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Hi @mvegter! This is looking pretty good. I've left some comments. Additionally, can you:
- run
make clto add a changelog entry - add documentation for this new config value to
website/content/docs/configuration/client.mdx. This should warn about the potential impact to cardinality.
Thanks for this PR!
mvegter
force-pushed
the
mvegter-include-job-meta-in-base-labels
branch
from
99e74f9
to
0ef9371
Compare
mvegter
force-pushed
the
mvegter-include-job-meta-in-base-labels
branch
from
0ef9371
to
b377e5e
Compare
mvegter
force-pushed
the
mvegter-include-job-meta-in-base-labels
branch
from
b377e5e
to
c447d94
Compare
mvegter
force-pushed
the
mvegter-include-job-meta-in-base-labels
branch
from
c447d94
to
f51d2e0
Compare
mvegter
force-pushed
the
mvegter-include-job-meta-in-base-labels
branch
from
f51d2e0
to
400856e
Compare
|
Thanks for the feedback @tgross , I have updated the |
mvegter
force-pushed
the
mvegter-include-job-meta-in-base-labels
branch
from
400856e
to
825f5a2
Compare
mvegter
force-pushed
the
mvegter-include-job-meta-in-base-labels
branch
from
4fbcab3
to
9aa6b0a
Compare
|
Ok, this has been merged and will ship in Nomad 1.9.0. Thanks for the contribution @mvegter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a stab at the following tickets / discussions :
First time opening a pull request using Go , feedback is much appreciated !