[ui] Version Tags on the job versions page #24013

philrenaud · 2024-09-19T15:05:52Z

Version tag CRUD in the UI. Allows a user to create, modify, and remove version tags.

github-actions · 2024-09-19T15:20:35Z

Ember Test Audit comparison

	23846-nomad-job-tag-cli-command-scaffolding	`74aae33`	change
passes	1578	1581	+3
failures	0	0	0
flaky	0	0	0
duration	11m 54s 608ms	12m 07s 568ms	+12s 960ms

philrenaud · 2024-09-24T03:43:12Z

ui/app/templates/components/job-version.hbs

+    <footer class="boxed-section-foot {{if this.isEditing "editing"}}">
+      {{#if this.isEditing}}
+        <form class="tag-options" autocomplete="off" {{on "submit" (action "saveTag")}}>
+          {{! template-lint-disable no-down-event-binding }}


This is to prevent {{on "keydown" (action this.handleKeydown)}} from throwing a linting error. This method watches for an ESC keypress to close edit mode.

I have a difference of opinion with our linter, expressed better than I can do it at https://x.com/ID_AA_Carmack/status/1787850053912064005

philrenaud · 2024-09-24T05:13:53Z

nomad/job_endpoint.go

+	if args.Tag != nil {
+		reply.Name = args.Tag.Name
+		reply.Description = args.Tag.Description
+		reply.TaggedTime = args.Tag.TaggedTime
+	}


Side effect: wanted to use the POST/PUT response here and realized I was sending back instantiated-but-not-populated data.

non-blocking: this reflects back to the user just what they passed in, but so long as we can depend on the raftApply erroring if it failed to enact their intentions, then this seems fine.

philrenaud · 2024-09-24T05:14:37Z

ui/app/templates/components/two-step-button.hbs

@@ -32,7 +32,7 @@
  />
  <Hds::Button
    data-test-confirm-button
-    @size="medium"
+    @size={{@size}}


Side effect: our two-step-buttons were always medium sized. This gives them all the flexibility of our other Helios buttons.

gulducat

looks good to my untrained eye! (and the walkthrough you gave us made enough sense)

* Tag and Untag at API level on down, but am I unblocking the wrong thing? * Code and comment cleanup * Unset methods generally now I stare long into the namespace abyss * Namespace passes through with QueryOptions removed from a write requesting struct * Comment and PR review cleanup * Version back to VersionStr * Generally consolidate unset logic into apply for version tagging * Addressed some PR comments * Auth check and RPC forwarding * uint64 instead of pointer for job version after api layer and renamed copy * job tag command split into apply and unset * latest-version convenience handling moved to CLI command level * CLI tests for tagging/untagging * UI parts removed * Add to job table when unsetting job tag on latest version * Vestigial no more * Compare versions by name and version number with the nomad history command (#23889) * First pass at passing a tagname and/or diff version to plan/versions requests * versions API now takes compare_to flags * Job history command output can have tag names and descriptions * compare_to to diff-tag and diff-version, plus adding flags to history command * 0th version now shows a diff if a specific diff target is requested * Addressing some PR comments * Simplify the diff-appending part of jobVersions and hide None-type diffs from CLI * Remove the diff-tag and diff-version parts of nomad job plan, with an eye toward making them a new top-level CLI command soon * Version diff tests * re-implement JobVersionByTagName * Test mods and simplification * Documentation for nomad job history additions * Prevent pruning and reaping of TaggedVersion jobs (#23983) tagged versions should not count against JobTrackedVersions i.e. new job versions being inserted should not evict tagged versions and GC should not delete a job if any of its versions are tagged Co-authored-by: Daniel Bennett <[email protected]> --------- Co-authored-by: Daniel Bennett <[email protected]> * [ui] Version Tags on the job versions page (#24013) * Timeline styles and their buttons modernized, and tags added * styled but not yet functional version blocks * Rough pass at edit/unedit UX * Styles consolidated * better UX around version tag crud, plus adapter and serializers * Mirage and acceptance tests * Modify percy to not show time-based things --------- Co-authored-by: Daniel Bennett <[email protected]>

* TaggedVersion information in structs, rather than job_endpoint (#23841) * TaggedVersion information in structs, rather than job_endpoint * Test for taggedVersion description length * Some API plumbing * Tag and Untag job versions (#23863) * Tag and Untag at API level on down, but am I unblocking the wrong thing? * Code and comment cleanup * Unset methods generally now I stare long into the namespace abyss * Namespace passes through with QueryOptions removed from a write requesting struct * Comment and PR review cleanup * Version back to VersionStr * Generally consolidate unset logic into apply for version tagging * Addressed some PR comments * Auth check and RPC forwarding * uint64 instead of pointer for job version after api layer and renamed copy * job tag command split into apply and unset * latest-version convenience handling moved to CLI command level * CLI tests for tagging/untagging * UI parts removed * Add to job table when unsetting job tag on latest version * Vestigial no more * Compare versions by name and version number with the nomad history command (#23889) * First pass at passing a tagname and/or diff version to plan/versions requests * versions API now takes compare_to flags * Job history command output can have tag names and descriptions * compare_to to diff-tag and diff-version, plus adding flags to history command * 0th version now shows a diff if a specific diff target is requested * Addressing some PR comments * Simplify the diff-appending part of jobVersions and hide None-type diffs from CLI * Remove the diff-tag and diff-version parts of nomad job plan, with an eye toward making them a new top-level CLI command soon * Version diff tests * re-implement JobVersionByTagName * Test mods and simplification * Documentation for nomad job history additions * Prevent pruning and reaping of TaggedVersion jobs (#23983) tagged versions should not count against JobTrackedVersions i.e. new job versions being inserted should not evict tagged versions and GC should not delete a job if any of its versions are tagged Co-authored-by: Daniel Bennett <[email protected]> --------- Co-authored-by: Daniel Bennett <[email protected]> * [ui] Version Tags on the job versions page (#24013) * Timeline styles and their buttons modernized, and tags added * styled but not yet functional version blocks * Rough pass at edit/unedit UX * Styles consolidated * better UX around version tag crud, plus adapter and serializers * Mirage and acceptance tests * Modify percy to not show time-based things --------- Co-authored-by: Daniel Bennett <[email protected]> * Job revert command and API endpoint can take a string version tag name (#24059) * Job revert command and API endpoint can take a string version tag name * RevertOpts as a signature-modified alternative to Revert() * job revert CLI test * Version pointers in endpoint tests * Dont copy over the tag when a job is reverted to a version with a tag * Convert tag name to version number at CLI level * Client method for version lookup by tag * No longer double-declaring client * [ui] Add tag filter to the job versions page (#24064) * Rough pass at the UI for version diff dropdown * Cleanup and diff fetching via adapter method * TaggedVersion now VersionTag (#24066) --------- Co-authored-by: Daniel Bennett <[email protected]>

philrenaud self-assigned this Sep 19, 2024

vercel bot deployed to Preview – nomad-ui September 19, 2024 21:03 View deployment

philrenaud force-pushed the 23846-nomad-job-tag-cli-command-scaffolding branch from 21ec042 to 7568f47 Compare September 20, 2024 14:55

vercel bot deployed to Preview – nomad-ui September 20, 2024 20:54 View deployment

vercel bot deployed to Preview – nomad-ui September 24, 2024 02:28 View deployment

philrenaud force-pushed the 24008-version-tag-crud-on-the-jobversions-page branch from 5bf56ec to 74cb5db Compare September 24, 2024 03:16

vercel bot deployed to Preview – nomad-ui September 24, 2024 03:18 View deployment

philrenaud force-pushed the 24008-version-tag-crud-on-the-jobversions-page branch from 74cb5db to d4efed1 Compare September 24, 2024 03:39

vercel bot deployed to Preview – nomad-ui September 24, 2024 03:40 View deployment

philrenaud commented Sep 24, 2024

View reviewed changes

vercel bot deployed to Preview – nomad-ui September 24, 2024 05:13 View deployment

philrenaud commented Sep 24, 2024

View reviewed changes

philrenaud requested review from gulducat and mismithhisler September 24, 2024 05:16

philrenaud marked this pull request as ready for review September 24, 2024 05:16

philrenaud force-pushed the 23846-nomad-job-tag-cli-command-scaffolding branch from 7568f47 to 185ec20 Compare September 24, 2024 13:30

philrenaud force-pushed the 24008-version-tag-crud-on-the-jobversions-page branch from 8421dfc to 76574d5 Compare September 24, 2024 13:47

vercel bot deployed to Preview – nomad-ui September 24, 2024 13:49 View deployment

aimeeu added the theme/golden-versions Tagging and preserving job versions label Sep 24, 2024

philrenaud force-pushed the 23846-nomad-job-tag-cli-command-scaffolding branch from 2dcc1f7 to f0905e8 Compare September 24, 2024 20:07

philrenaud added 5 commits September 24, 2024 16:09

Timeline styles and their buttons modernized, and tags added

f545264

styled but not yet functional version blocks

5c848ad

Rough pass at edit/unedit UX

ae21a50

Styles consolidated

e817aca

better UX around version tag crud, plus adapter and serializers

38cb9ab

philrenaud force-pushed the 24008-version-tag-crud-on-the-jobversions-page branch from 76574d5 to 402087f Compare September 24, 2024 20:10

vercel bot deployed to Preview – nomad-ui September 24, 2024 20:11 View deployment

Mirage and acceptance tests

44c9e2d

philrenaud force-pushed the 24008-version-tag-crud-on-the-jobversions-page branch from 402087f to 44c9e2d Compare September 24, 2024 20:13

vercel bot deployed to Preview – nomad-ui September 24, 2024 20:15 View deployment

Modify percy to not show time-based things

74aae33

vercel bot deployed to Preview – nomad-ui September 25, 2024 13:37 View deployment

gulducat approved these changes Sep 25, 2024

View reviewed changes

philrenaud merged commit 30c743d into 23846-nomad-job-tag-cli-command-scaffolding Sep 25, 2024
28 checks passed

philrenaud deleted the 24008-version-tag-crud-on-the-jobversions-page branch September 25, 2024 18:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ui] Version Tags on the job versions page #24013

[ui] Version Tags on the job versions page #24013

philrenaud commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading

philrenaud Sep 24, 2024

philrenaud Sep 24, 2024

gulducat Sep 25, 2024

philrenaud Sep 24, 2024

gulducat left a comment

[ui] Version Tags on the job versions page #24013

[ui] Version Tags on the job versions page #24013

Conversation

philrenaud commented Sep 19, 2024 • edited Loading

github-actions bot commented Sep 19, 2024 • edited Loading

Ember Test Audit comparison

philrenaud Sep 24, 2024

Choose a reason for hiding this comment

philrenaud Sep 24, 2024

Choose a reason for hiding this comment

gulducat Sep 25, 2024

Choose a reason for hiding this comment

philrenaud Sep 24, 2024

Choose a reason for hiding this comment

gulducat left a comment

Choose a reason for hiding this comment

philrenaud commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading