[ui] Ember test suite upgraded #24020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
philrenaud
force-pushed
the
24019-ui-upgrade-body-parser-and-ember-a11y-testing-and-related-dependencies
branch
from
794bf70
to
83da69f
Compare
Ember Test Audit comparison
|
dduzgun-security
approved these changes
Sep 20, 2024
philrenaud
commented
Sep 20, 2024
| <script src="{{ rootURL }}assets/vendor.js"></script> | ||
| <script src="{{ rootURL }}assets/test-support.js"></script> | ||
| <script src="{{ rootURL }}assets/nomad-ui.js"></script> | ||
| <script src="/testem.js" integrity="" data-embroider-ignore></script> |
There was a problem hiding this comment.
Now that we specify a framework in testem directly, it appears that script loading order matters.
philrenaud
deleted the
24019-ui-upgrade-body-parser-and-ember-a11y-testing-and-related-dependencies
branch
philrenaud
added a commit
that referenced
this pull request
Sep 24, 2024
* Ember test suite upgraded * Switch up the order for the sake of testem * Use the built-in ember test helper render for job editor rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24019
Resolves https://github.com/hashicorp/nomad/security/code-scanning/674