azuread_conditional_access_policy: support includeAuthenticationContextClassReferences and applicationFilter of conditions #1534
+54
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenchan0130
force-pushed
the
patch-882
branch
from
5641f20
to
3887987
Compare
…lter of azuread_conditional_access_policy.conditions resource
kenchan0130
force-pushed
the
patch-882
branch
from
3887987
to
68b2904
Compare
kenchan0130
commented
Oct 17, 2024
| * `included_user_actions` - (Optional) A list of user actions to include. Supported values are `urn:user:registerdevice` and `urn:user:registersecurityinfo`. Cannot be specified with `included_applications`. One of `included_applications` or `included_user_actions` must be specified. | ||
| * `filter` - (Optional) A `filter` block as described below. | ||
| * `included_applications` - (Optional) A list of application IDs the policy applies to, unless explicitly excluded (in `excluded_applications`). Can also be set to `All`, `None` or `Office365`. Cannot be specified with `included_user_actions`. One of `included_applications`, `included_user_actions` or `included_authentication_context_class_references` must be specified. | ||
| * `included_authentication_context_class_references` - (Optional) A list of authentication context class reference to include. Supported values are `c1` through `c99`. |
There was a problem hiding this comment.
I see in the API docs that it only supports IDs up to c25,
In fact, the official doc states that IDs can be used up to c99.
jackofallops
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Hi @kenchan0130 - before we do a full review, can you add acceptance test coverage for the new properties and validation conditions?
Thanks
This provider does not yet have a terraform resource to create an authentication context. So unfortunately I am unable to add a test on the attributes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: #882 #1318
Related to #1357