Add extra tests

hashicorp · Apr 19, 2024 · 74717c2 · 74717c2
1 parent d4e739e
commit 74717c2
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 28 deletions.
diff --git a/examples/test/main.tf b/examples/test/main.tf
diff --git a/internal/provider/vaultsecrets/resource_vault_secrets_app_test.go b/internal/provider/vaultsecrets/resource_vault_secrets_app_test.go
@@ -31,6 +31,17 @@ func TestAccVaultSecretsResourceApp(t *testing.T) {
 					resource.TestCheckResourceAttr("hcp_vault_secrets_app.example", "project_id", projectID),
 				),
 			},
+			{
+				Config: fmt.Sprintf(`
+					resource "hcp_vault_secrets_app" "example" {
+						app_name = %q
+						description = "Acceptance test run"
+				  }`, testAppName),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("hcp_vault_secrets_app.example", "app_name", testAppName),
+					resource.TestCheckResourceAttr("hcp_vault_secrets_app.example", "description", "Acceptance test run"),
+				),
+			},
 		},
 	})
 }
diff --git a/internal/provider/vaultsecrets/resource_vault_secrets_secret_test.go b/internal/provider/vaultsecrets/resource_vault_secrets_secret_test.go
@@ -13,23 +13,41 @@ import (
 )
 
 func TestAccVaultSecretsResourceSecret(t *testing.T) {
-	testAppName := generateRandomSlug()
+	testAppName1 := generateRandomSlug()
+	testAppName2 := generateRandomSlug()
 	projectID := os.Getenv("HCP_PROJECT_ID")
 	resource.Test(t, resource.TestCase{
 		ProtoV6ProviderFactories: acctest.ProtoV6ProviderFactories,
 		Steps: []resource.TestStep{
+
+			{
+				PreConfig: func() {
+					createTestApp(t, testAppName1)
+				},
+				Config: fmt.Sprintf(`
+				resource "hcp_vault_secrets_secret" "example" {
+					app_name = %q
+					secret_name = "test_secret"
+					secret_value = "super secret"
+				}`, testAppName1),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "app_name", testAppName1),
+					resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "secret_name", "test_secret"),
+					resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "secret_value", "super secret"),
+				),
+			},
 			{
 				PreConfig: func() {
-					createTestApp(t, testAppName)
+					createTestApp(t, testAppName2)
 				},
 				Config: fmt.Sprintf(`
 				resource "hcp_vault_secrets_secret" "example" {
 					app_name = %q
 					secret_name = "test_secret"
 					secret_value = "super secret"
-				}`, testAppName),
+				}`, testAppName2),
 				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "app_name", testAppName),
+					resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "app_name", testAppName2),
 					resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "secret_name", "test_secret"),
 					resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "secret_value", "super secret"),
 					resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "project_id", projectID),