Wait for module version to be created if the no-code version_pin is set

[dsa0x]

Description

• This makes the change to wait for the registry module version to be ingressed, before creating the no-code module. Otherwise, the no-code variable options will not be created on first try since the version may not exist, and variable options are tied to a specific version of the module.
• This change also enforces that the variable options attribute must be used with the version_pin attribute, i.e if the variable options is set, then the version pin must also be set.

Remember to:

• Update the Change Log
• Update the Documentation

Testing plan

1. Set the following environment variables

os.Setenv("TF_ACC", "1")
	os.Setenv("TFE_HOSTNAME", "E.g app.staging.terraform.io")
	os.Setenv("TFE_TOKEN", "sd4HQNPs.atlasv1.fccmoesk")
	os.Setenv("GITHUB_REGISTRY_MODULE_IDENTIFIER", "hashicorp/terraform-random-module")
	os.Setenv("GITHUB_TOKEN", "ghp_uofoobarbaz")

2. Ensure that the github token can access the hashicorp module
3. Ensure that the tfe token is from a business organization (so that no-code feature can be accessed).
4. Run the test with go test -v -timeout 60s -run ^TestAccTFENoCodeModule_with_variable_options$ github.com/hashicorp/terraform-provider-tfe/internal/provider
5. The test should pass

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

• go-tfe documentation
• Related PR
• Issue Link

Output from acceptance tests

$ go test -v -timeout 60s -run ^TestAccTFENoCodeModule_with_variable_options$ github.com/hashicorp/terraform-provider-tfe/internal/provider
=== RUN   TestAccTFENoCodeModule_with_variable_options
--- PASS: TestAccTFENoCodeModule_with_variable_options (16.10s)
PASS
ok      github.com/hashicorp/terraform-provider-tfe/internal/provider   16.575s

...