fix the windows hyperv smb synced folder creation/destruction #12933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rgl
force-pushed
the
rgl-fix-windows-hyperv-smb-synced-folder
branch
2 times, most recently
from
9154771
to
a5a806b
Compare
soapy1
force-pushed
the
rgl-fix-windows-hyperv-smb-synced-folder
branch
from
a5a806b
to
ecc4539
Compare
|
Heya, sorry for taking so long to get to this. I rebased on main and forced pushed to get the tests to run. Aiming to get this tested/merged soon! |
|
LGTM! also pushed up some changes for test |
soapy1
approved these changes
Feb 14, 2023
phinze
approved these changes
Feb 22, 2023
|
Is removing UAC validation the best approach here? It seems like a regression; If I understood correctly you came to the conclusion that the root cause is failed UAC prompting/alerting, were you able to track down the cause/trigger/reason? |
|
@OnceUponALoop I was not able to track the root cause. check the related issue, it might have more clue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12639
please note that the uac code was removed, as such, the user has to always run vagrant from an elevated shell.
I removed it because the smb share creating and removal was not working in an elevated shell.