fix role update endpoint and provide patch method #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y use defaults fields if not provided, and add PATCH for role path
|
Hi @tvoran , is there anything else that you would want done in this PR? |
|
Any update about this @tvoran ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix the update endpoint for the role configuration to behave according to POST RESTful definitions. Add a PATCH endpoint for the role configuration.
This change might affect users that misuse the POST endpoints to update individual fields in the role configuration. If they omit required fields, this will now return an error, and if they simply omit fields, these will not be changed back to defaults (as opposed to keeping the value that was previously configured).
Design of Change
I reused most of the code that used to be the update function for the patch method (as it actually behaved like a patch). Also refactored some code into own methods to reduce code duplication.
Related Issues/Pull Requests
[ ] Issue #163
[ ] Vault PR #17371
Contributor Checklist
[x] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
Vault PR #17461
[ ] Backwards compatible