This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
RELENG-619 - version updates to better support CRT/VBA #4828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to better support CRT/VBA.
sarahethompson
requested review from
dekimsey and
emilymianeil
and removed request for
a team
sarahethompson
added
pr/no-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hashicorp.atlassian.net/browse/RELENG-619. This will mean the current version will only need to be maintained in one place (
VERSIONfile).internal/version/version.go->version/version.goso that we cango:embedtheVERSIONfileVersionandVersionPrereleasedirectly from theVERSIONfileVersionandVersionPrereleasevialdflagsat build time (CRT)https://github.com/hashicorp/waypoint/actions/runs/5455886991