This repository has been archived by the owner on Oct 29, 2021. It is now read-only.
Allows IO in validation keyset #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erewok
reviewed
Aug 5, 2020
| data JWTSettings | ||
| = JWTSettings | ||
| { -- | Key used to sign JWT. | ||
| signingKey :: Jose.JWK, |
There was a problem hiding this comment.
In the Okta or Auth0 case, we wouldn't have a signing key. We can only validate using public keys. Should this signing key always be required? We could make a dummy one, of course...
There was a problem hiding this comment.
Yeah, it's a perpetual awkwardness of this library. The signing key is used for cookies (since those are also JWTs). There is sometimes an advantage to having it, since you can store data that's different than whatever you got during login, but it's really annoying to make it (and cookies) optional.
There was a problem hiding this comment.
Fair enough! Thanks again for working on this.
|
Any progress on this? I think this approach is a good one and thanks for working on it @jkarni |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153
I still want to try this out before merging. Note that it also should follow #168.