use monotonic clock instead of system clock #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand the build failure. I want to believe that it is not due to changes in this PR (since I did not change any types) but the last build of |
|
This change looks good overall. Once we have the main branch compiling again we can merge this |
arianvp
approved these changes
Jan 24, 2022
|
@bergey if you rebase you should trigger CI again and this can be merged |
bergey
force-pushed
the
monotonic-ghc.clock
branch
from
e05c471 to
d9387b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monotonic clock appears to be faster to query, as well as alledgedly more accurate. Closes #13.
Running the benchmark on my Macbook, I see 10-30 microseconds for the version in this PR, vs ~130 microseconds for the version in
master.