Renamed AtLeastOneFragment type class to AtMostOneFragment
#1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidMazarro
changed the title
AtLeastOneFragment to AtMostOneFragmentAtLeastOneFragment type class to AtMostOneFragment
|
@jkarni would you mind giving your opinion on this? |
|
@DavidMazarro Thanks for the PR! |
|
(I added these last two commits because I was unfamiliar with |
|
Feel free to run the CI on this one again, but other than that it's ready to merge from my side :) |
|
@tchoutri could you run the CI workflow again? |
|
Alright, I have looked up the usage of Thanks @DavidMazarro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless I'm misunderstanding the
FragmentUniquetype family, it's checking that there's at most one fragment in the API type. In that case, theAtLeastOneFragmentname is not only confusing, but potentially misleading. This PR renames the type class toAtMostOneFragment.In addition, I did some small changes to the documentation, I moved the explanation of the type class to the type class definition (previously the comment was under the
Verbinstance) and reworded it a bit.