Remove base-compat dependency from servant #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchoutri
force-pushed
the
remove-base-compat-dependency-from-servant
branch
from
904876e
to
448267a
Compare
MangoIV
reviewed
Apr 26, 2024
Comment on lines
673
to
676
| instance {-# OVERLAPPABLE #-} TypeError (NoInstanceForSub | ||
|
|
||
| #if __GLASGOW_HASKELL__ >= 904 | ||
| @(Type -> Constraint) | ||
|
|
||
| #endif |
There was a problem hiding this comment.
You're watching the second commit, which reinstates these lines after they were mistakenly removed in the first commit.
ysangkok
approved these changes
Apr 29, 2024
|
Do I understand correctly that these changes (and ones in #1745) do not have to be released on their own, but can wait until next big release of respective packages? |
|
Yes they should be fairly transparent for the end users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First batch of removing extraneous dependencies.