Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hashable-1.4 #324

Merged
merged 1 commit into from
Nov 7, 2021
Merged

Support hashable-1.4 #324

merged 1 commit into from
Nov 7, 2021

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Nov 1, 2021

@sjakobi
Copy link
Member Author

sjakobi commented Nov 1, 2021

I was wondering whether we should update constraints like (Eq k, Hashable k). @phadej has convinced me not to do this for now in haskell-unordered-containers/hashable#232 (comment). Instead, we can consider requiring hashable >= 1.4 in a few months and enabling -Wredundant-constraints then.

@sjakobi sjakobi requested a review from treeowl November 1, 2021 12:57
@sjakobi sjakobi mentioned this pull request Nov 1, 2021
Closed
@sjakobi
Copy link
Member Author

sjakobi commented Nov 2, 2021

Ping @treeowl. I'd like to make a release including this patch soon.

@phadej
Copy link
Contributor

phadej commented Nov 5, 2021 •
edited
Loading

I checked that CI indeed picks up hashable-1.4.0.0 as a dependency. Ping @treeowl .

In the meantime, @sjakobi do you mind adding 9.2.1 job to CI? EDIT: looks like it is added in master, but this PR is not on top of ci-job-adding commit?

@treeowl
Copy link
Collaborator

treeowl commented Nov 5, 2021

Sounds like a plan.

@tchoutri tchoutri mentioned this pull request Nov 5, 2021
Closed
@sjakobi sjakobi merged commit 23303a6 into master Nov 7, 2021
@sjakobi sjakobi deleted the sjakobi/hashable-1.4 branch November 7, 2021 04:27
@sjakobi
Copy link
Member Author

sjakobi commented Nov 7, 2021

@phadej I've checked locally that this branch builds with GHC 9.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treeowl treeowl treeowl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjakobi @phadej @treeowl