Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #700. Expose GToJSON. #775

Merged
merged 1 commit into from
May 25, 2020
Merged

Resolve #700. Expose GToJSON. #775

merged 1 commit into from
May 25, 2020

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented May 16, 2020

Rename the type-class to be GToJSON' (with prime),
to avoid name clash with type-aliases GToJSON and GToEncoding

This is the second of remaining 1.5 tasks.

@phadej
Resolve haskell#700. Expose GToJSON.
dd2ace9 
Rename the type-class to be `GToJSON'` (with prime),
to avoid name clash with type-aliases GToJSON and GToEncoding
@phadej
Copy link
Collaborator Author

phadej commented May 16, 2020

EDIT: In fact, I'll be happy with the state for 1.5 to be released. #653 needs a bit of thinking, I won't have time for that soon. (And we have another major release on the horizon with scanner stuff). So let's not wait any longer. ping @bergmark

@bergmark bergmark added this to the v1.5.0.0 milestone May 25, 2020
@bergmark
Copy link
Collaborator

Thanks!

@bergmark bergmark merged commit 95287fe into haskell:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phadej @bergmark