Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for bytestring-0.12.2.0 #696

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

Bodigrim
Copy link
Contributor

No description provided.

@Bodigrim Bodigrim added this to the 0.12.2.0 milestone Oct 15, 2024
@Bodigrim Bodigrim requested a review from clyring October 15, 2024 22:48
@clyring
Copy link
Member

clyring commented Oct 20, 2024

The existing entries and organization look good to me.

Also, we are still only working around #665 in a Hackage revision. We should fix it properly (or at least merge the contents of the Hackage revision into the source repo) before cutting a release. I can prepare a MR for this tomorrow, if you don't beat me to it.

@Bodigrim
Copy link
Contributor Author

Technically this is a breaking change as-is, since the use of packUptoLenBytes means that the input list will be truncated if the list is longer than the size hint suggests.

Yeah, maybe it's better to revert the change to instance IsList StrictByteString.

We should fix it properly (or at least merge the contents of the Hackage revision into the source repo)

Let's make our lives easier and just backport the revision.


Feel free to push any corrections into this branch.

@Bodigrim
Copy link
Contributor Author

Bodigrim commented Dec 5, 2024

Updated now, I reverted changes to instance IsList ByteString in bytestring-0.12 branch.

@clyring we are being chased by GHC team to make a release asap. If there are no more comments by Friday evening, I'll merge this and release bytestring-0.12.2.0.

Copy link
Member

@clyring clyring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I went ahead and added a few (invisible) entries for the last backports.

The commit message for 537b8ac unfortunately refers to the wrong PR.

Thanks much for working on this! Sorry for disappearing on you these past few weeks.

@Bodigrim Bodigrim merged commit c73756a into haskell:master Dec 6, 2024
28 checks passed
@Bodigrim Bodigrim deleted the changelog-0.12.2.0 branch December 6, 2024 21:03
Bodigrim added a commit that referenced this pull request Dec 6, 2024
* Update changelog for bytestring-0.12.2.0

* Add invisible changelog entries for the latest backports

---------

Co-authored-by: Matthew Craven <[email protected]>
# Conflicts:
#	Changelog.md
Bodigrim added a commit that referenced this pull request Dec 6, 2024
* Update changelog for bytestring-0.12.2.0

* Add invisible changelog entries for the latest backports

---------

Co-authored-by: Matthew Craven <[email protected]>
# Conflicts:
#	Changelog.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants