-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple QuickCheck test for solver exceptions #10234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffaf1
approved these changes
Jul 30, 2024
ulysses4ever
approved these changes
Jul 30, 2024
Formating issue: - let r = solve
+ let r =
+ solve https://github.com/haskell/cabal/actions/runs/10157383530/job/28087388116?pr=10234 |
grayjay
force-pushed
the
quickcheck-solver-exceptions
branch
from
August 5, 2024 07:34
fa651d7
to
3bfcef9
Compare
grayjay
force-pushed
the
quickcheck-solver-exceptions
branch
from
August 5, 2024 07:39
3bfcef9
to
50fcf56
Compare
Thanks! |
mergify
bot
added
the
merge delay passed
Applied (usually by Mergify) when PR approved and received no updates for 2 days
label
Aug 7, 2024
The solver QuickCheck tests can already detect exceptions, but this test is simpler and easier to debug.
Mikolaj
force-pushed
the
quickcheck-solver-exceptions
branch
from
August 7, 2024 07:42
50fcf56
to
3347001
Compare
@mergify backport 3.12 |
✅ Backports have been created
|
2 tasks
mergify bot
added a commit
that referenced
this pull request
Sep 13, 2024
Add simple QuickCheck test for solver exceptions (backport #10234)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cabal-install: solver
merge delay passed
Applied (usually by Mergify) when PR approved and received no updates for 2 days
merge me
Tell Mergify Bot to merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solver QuickCheck tests can already detect exceptions, but this test is simpler and easier to debug.
This PR doesn't have a corresponding issue because it only adds tests.