Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple QuickCheck test for solver exceptions #10234

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

grayjay
Copy link
Collaborator

@grayjay grayjay commented Jul 30, 2024

The solver QuickCheck tests can already detect exceptions, but this test is simpler and easier to debug.


This PR doesn't have a corresponding issue because it only adds tests.


  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@ulysses4ever
Copy link
Collaborator

Formating issue:

-         let r = solve
+         let r =
+               solve

https://github.com/haskell/cabal/actions/runs/10157383530/job/28087388116?pr=10234

@grayjay
Copy link
Collaborator Author

grayjay commented Aug 5, 2024

Thanks!

@grayjay grayjay added the merge me Tell Mergify Bot to merge label Aug 5, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Aug 7, 2024
The solver QuickCheck tests can already detect exceptions, but this test is
simpler and easier to debug.
@Mikolaj Mikolaj force-pushed the quickcheck-solver-exceptions branch from 50fcf56 to 3347001 Compare August 7, 2024 07:42
@mergify mergify bot merged commit 1eb0bb2 into haskell:master Aug 7, 2024
49 checks passed
@grayjay grayjay deleted the quickcheck-solver-exceptions branch August 7, 2024 20:23
@geekosaur
Copy link
Collaborator

@mergify backport 3.12

Copy link
Contributor

mergify bot commented Aug 30, 2024

backport 3.12

✅ Backports have been created

mergify bot added a commit that referenced this pull request Sep 13, 2024
Add simple QuickCheck test for solver exceptions (backport #10234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cabal-install: solver merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants