Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use fixed cabal version per #10175 #10251

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

geekosaur
Copy link
Collaborator

@geekosaur geekosaur commented Aug 8, 2024

Implement #10175 by fixing cabal version to (for now) 3.12.1.* (originally 3.10.3.0 but that broke tests added post-3.10). We should decide when we should update this and record it and its rationale in the making-a-release wiki page.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur
Copy link
Collaborator Author

Some change in master requires 3.12.1.0 minimum for validate to pass. It'll be interesting to see if this backports… but since we're already preparing for 3.14, a backport isn't mandatory unless we retroactively declare 3.12 an LTS branch. Which might be necessary if we're going to release major versions on GHC's schedule.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! This should indeed resolve #10175

.github/workflows/validate.yml Outdated Show resolved Hide resolved
@geekosaur geekosaur marked this pull request as ready for review August 8, 2024 20:36
@geekosaur geekosaur force-pushed the fixed-setup-haskell branch 2 times, most recently from bc59c37 to 3632224 Compare August 8, 2024 23:32
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@geekosaur geekosaur added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Aug 9, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Aug 11, 2024
@mergify mergify bot merged commit 6bf766f into haskell:master Aug 11, 2024
49 checks passed
@geekosaur
Copy link
Collaborator Author

@mergify backport 3.12

@geekosaur geekosaur deleted the fixed-setup-haskell branch August 30, 2024 21:19
Copy link
Contributor

mergify bot commented Aug 30, 2024

backport 3.12

✅ Backports have been created

mergify bot added a commit that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants