Cabal: Take into account compilerBuildWay when computing final library ways (backport #10419) #10422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…y ways In the profiling dynamic patch I made a mistake when computing the needed ways for a build. When building an executable, the Haskell modules need to be built * For the final link way * For the build way of the compiler if TH is enabled Before this patch, the modules were being built for all the configured library ways, which built modules in more configurations than the previous version of Cabal. Fixes #10418 (cherry picked from commit 27c2668)
7 tasks
geekosaur
approved these changes
Oct 4, 2024
20 tasks
|
MacOS doesn't like it, apparently? https://github.com/haskell/cabal/actions/runs/11180765963/job/31083224884?pr=10422#step:19:615 |
Patches the component build ways for foreign library components.
|
I've applied an additional fix to build ways of foreign libraries to fix the CI error. |
|
Can we merge this please? We need these patches in the 3.14 branch to allow the Cabal submodule in GHC to be updated to the branch. |
Kleidukos
added
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the profiling dynamic patch I made a mistake when computing the needed ways for a build.
When building an executable, the Haskell modules need to be built
Before this patch, the modules were being built for all the configured library ways, which built modules in more configurations than the previous version of Cabal.
Fixes #10418
Please read Github PR Conventions and then fill in one of these two templates.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR:
This is an automatic backport of pull request #10419 done by [Mergify](https://mergify.com).