Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix LTS prerelease workflow #10429

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geekosaur
Copy link
Collaborator

It's being skipped, not failing to fire, implying the wrong ref? This subsumes #10415.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions). (3.12 only; 3.14 isn't an LTS release.)

@geekosaur
Copy link
Collaborator Author

Untestable until backported. ☹

@geekosaur
Copy link
Collaborator Author

@mergify backport 3.12

Copy link
Contributor

mergify bot commented Oct 5, 2024

backport 3.12

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

@geekosaur
Copy link
Collaborator Author

Well, not quite true, I pushed the conditional down into the actually-make-the-release step so I can verify the rest (and already found one bug) and in particular check why it's skipping (which it should in the PRs and on master but not when it lands on 3.12).

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's see if this works fine.

@geekosaur
Copy link
Collaborator Author

geekosaur commented Oct 5, 2024

Per my previous comment, it won't; I'm trying to determine why with this update, along with trying a few things that I'm now pretty sure won't work. The main point, though, is to get some debug output about why it's not running when it's supposed to (currently it's always skipped even when merging to 3.12 branch). Hopefully when this lands in 3.12 it'll tell me enough that I can submit a follow-on that does make it work.

@geekosaur
Copy link
Collaborator Author

I'm not sure if the LTS prerelease should include the LTS designation in the filenames. I'm currently (once I get the code working) including it, but it could be argued that it shouldn't be there.

It's being skipped, not failing to fire, implying the wrong ref?
This subsumes haskell#10415.
@geekosaur geekosaur added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Oct 10, 2024
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous-integration merge me Tell Mergify Bot to merge re: long-term support branch ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants