Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split internals into their own package #200

Closed
wants to merge 1 commit into from
Closed

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Jul 25, 2023

  1. split internals into filepath-internals package
  2. expose unsafeFromBytes in public API (previously fromBytes)
  3. rename System.OsString.Internal.Types to System.OsString.Types.Internal
  4. un-expose System.OsPath.Windows.Internal and System.OsPath.Posix.Internal

Point 2. and 4. were mostly done so that I don't have to move the entire implementation into filepath-internals. If we want to avoid those changes... this PR will become much more involved.

Also: strictly speaking, this change is not PVP compliant.

@hasufell hasufell requested a review from Bodigrim July 25, 2023 13:45
@hasufell hasufell force-pushed the filepath-internals branch 2 times, most recently from 2feb76e to 41038d8 Compare July 25, 2023 13:48
@hasufell hasufell force-pushed the filepath-internals branch 2 times, most recently from 456228a to 1293649 Compare July 25, 2023 13:51
Copy link
Contributor

@Bodigrim Bodigrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but I think such restructuring warrants a major version bump.

@hasufell hasufell closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants