Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve test function write_read #593

Merged
merged 7 commits into from
May 19, 2024

Conversation

BebeSparkelSparkel
Copy link
Contributor

@BebeSparkelSparkel BebeSparkelSparkel commented May 2, 2024

Now tests different encodings not just UTF8.
Removed NFData constraint so that Builder can be tested.

Should be pulled before hPutStr and hPutBuilder PRs

Copy link
Contributor

@Bodigrim Bodigrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on improving the test suite!

tests/Tests/Utils.hs Show resolved Hide resolved
tests/Tests/QuickCheckUtils.hs Outdated Show resolved Hide resolved
@Bodigrim Bodigrim requested a review from Lysxia May 8, 2024 22:51
tests/Tests/QuickCheckUtils.hs Outdated Show resolved Hide resolved
tests/Tests/QuickCheckUtils.hs Outdated Show resolved Hide resolved
@Bodigrim
Copy link
Contributor

@BebeSparkelSparkel this is unrelated to your work here, but could you please allow template-haskell-2.22 in the Cabal file? This would allow CI to pass.

@BebeSparkelSparkel
Copy link
Contributor Author

@Bodigrim #595

@Bodigrim
Copy link
Contributor

@BebeSparkelSparkel thanks a ton! Please rebase this PR.

@Bodigrim Bodigrim merged commit 8e2c9aa into haskell:master May 19, 2024
27 checks passed
@Bodigrim
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants