Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Servant and the Cryptography Group to the Affiliates page #190

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

Kleidukos
Copy link
Contributor

@Kleidukos Kleidukos commented Feb 22, 2022

This PR adds Servant & the Cryptography Group to the list of affiliates.

For reference:

Once the core members of these groups have expressed their votes, this PR will be marked as ready.

@Kleidukos Kleidukos requested a review from myShoggoth February 22, 2022 19:54
@tomjaguarpaw
Copy link
Contributor

It could be helpful from the point of view of auditability if this PR came with links to decisions or statements made by the maintainers of those projects (perhaps in the project READMEs) about their affiliation.

@Kleidukos
Copy link
Contributor Author

@tomjaguarpaw Absolutely, I'll link to both then the approval can proceed.

@Kleidukos Kleidukos marked this pull request as draft February 22, 2022 20:18
@Kleidukos Kleidukos marked this pull request as ready for review February 28, 2022 08:48
@Kleidukos
Copy link
Contributor Author

@tomjaguarpaw @myShoggoth The PR is ready, both groups have expressed their public approval.

@tomjaguarpaw
Copy link
Contributor

tomjaguarpaw commented Feb 28, 2022

That's great to hear! I think it would still be useful to leave links to the public approval here, so save people the time from searching for them.

[EDIT: they have already been linked in the top comment]

Nevertheless, I don't think that absence should block merging the PR.

@Kleidukos
Copy link
Contributor Author

@tomjaguarpaw Based on the other documents of affiliation in this repo I don't really see where we could put the public votes' links. But maybe you have something in mind?

@tomjaguarpaw
Copy link
Contributor

Oh, I just meant leave them in this PR discussion thread.

@tomjaguarpaw
Copy link
Contributor

I mean, I for one would like to see them, but I don't know where to look!

@tomjaguarpaw
Copy link
Contributor

Oh I beg your pardon: I didn't see you had edited your original message to include those links.

@Kleidukos
Copy link
Contributor Author

@tomjaguarpaw it's the "deploy" part of the CI that seems to return an exit code 1, do you think it's safe to merge?

@tomjaguarpaw
Copy link
Contributor

I don't see anything that actually went wrong with Deploy, even though it finished with exit code 1. So I suspect it is safe to merge, but on the other hand I don't know how to fix it if something goes wrong, so perhaps best to wait until we find someone who does know.

@myShoggoth myShoggoth merged commit 664668f into hakyll Feb 28, 2022
@myShoggoth myShoggoth deleted the add-servant-and-cryptography-group-affiliations branch February 28, 2022 15:46
@myShoggoth
Copy link
Contributor

myShoggoth commented Feb 28, 2022

The issue is that the CI stuff doesn't work right if you're not merging into Hakyll. !170 attempts to address this, but I haven't been able to verify that it works, and it changes a few core assumptions that need to be verified.

We fundamentally want CI to check the code vs. CI to deploy to be separate things, and only have the latter run on PRs to the Hakyll branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants