Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ED to website #207

Merged
merged 2 commits into from
May 2, 2022
Merged

Add new ED to website #207

merged 2 commits into from
May 2, 2022

Conversation

david-christiansen
Copy link
Contributor

This re-enables the "Executive team" section and adds me and my picture to it.

The existing pictures are not entirely consistent - some have lower resolution and a white circle, others are larger with a transparent border around the circle. I opted for the latter in the interests of flexibility, but in case I missed some commonality, I'm happy to modify it.

@david-christiansen
Copy link
Contributor Author

I don't understand the CI failure here. It looks like it's attempting to deploy the site somewhere, but that it's not doing so. But there's no error message.

Any suggestions on where to start diagnosing the issue?

Copy link
Contributor

@goldfirere goldfirere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One possible oversight; otherwise good. You're right that the images are non-uniform, something I discovered recently, too. I think this is historical accident. Your picture renders well on my screen.

who-we-are/people/davidchristiansen.markdown Show resolved Hide resolved
@goldfirere
Copy link
Contributor

The CI failure is expected. (I'm not sure how all the belts and gears work here.) To test, stack exec -- site build or cabal run -- site build locally, and then examine _site/index.html. When you merge, deployment is automatic and appears to work reliably.

For what it's worth, I tested this on my own machine, and all looks good.

Fixing the CI failure on branches appears to be the subject of #170, but I have not looked at this myself.

@david-christiansen
Copy link
Contributor Author

It looks good with a local test on my end too.

@goldfirere goldfirere merged commit d38a03d into hakyll May 2, 2022
@goldfirere
Copy link
Contributor

I took the liberty to merge. In general, I'm unaware of a specific protocol for who is supposed to merge for these PRs -- feel free to set down your own desired workflow here. :)

@david-christiansen david-christiansen deleted the add-david-c branch May 2, 2022 16:56
@david-christiansen
Copy link
Contributor Author

I generally like workflows where people don't merge their own PRs, assuming there's sufficient collaborators to make that practicable. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants