Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application of the “reporting” setting #304

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

QRPp
Copy link
Contributor

@QRPp QRPp commented Oct 26, 2023

Remove whitespace sensitivity of the sed code enforcing it; the default configuration file has spaces around the equals sign at the moment.

(Do the same to the application of the “auth” setting too. It works at the moment as is, but this is good for future-proofing.)

Proposed Changes

Restore the correct propagation of the “reporting” add-on setting to the “reporting-disabled” InfluxDB conf file setting.

Related Issues

Right now, the propagation's broken due to how the default configuration line uses whitespace.

Remove whitespace sensitivity of the sed code enforcing it; the default
configuration file has spaces around the equals sign at the moment.

(Do the same to the application of the “auth” setting too.  It works at the
moment as is, but this is good for future-proofing.)

This comment was marked as resolved.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Nov 26, 2023
@QRPp

This comment was marked as resolved.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Nov 27, 2023

This comment was marked as resolved.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Dec 28, 2023
@QRPp

This comment was marked as resolved.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Dec 29, 2023
@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Jan 7, 2024
@frenck
Copy link
Member

frenck commented Jan 7, 2024

Something is wrong with the CI (it doesn't run).

@frenck frenck closed this Jan 7, 2024
@frenck frenck reopened this Jan 7, 2024
@frenck
Copy link
Member

frenck commented Jan 7, 2024

A simple close & re-open seems to do the trick. Thanks GitHub 😬

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @QRPp 👍

../Frenck

@frenck frenck merged commit 3868096 into hassio-addons:main Jan 7, 2024
11 of 12 checks passed
@QRPp QRPp deleted the fix-reporting branch January 7, 2024 16:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants