Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested field filtering #47

Merged
merged 48 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
6f37dff
add script to run arbitrary SQL
codingkarthik Aug 26, 2024
69446d6
remove unused env vars
codingkarthik Aug 26, 2024
30215d4
use the linux binary directly
codingkarthik Aug 26, 2024
76d37b0
remove checking out ndc-spec
codingkarthik Aug 26, 2024
d7012b7
install libssl3
codingkarthik Aug 26, 2024
84cd0f5
generate the correct nested fields filtering predicate
codingkarthik Aug 29, 2024
7e168c6
generate the WHERE predicate for nested fields
codingkarthik Sep 3, 2024
0959bf6
get the recursion correct [WIP]
codingkarthik Sep 5, 2024
61d415e
get the binary comparison operator for a Column
codingkarthik Sep 6, 2024
77f1267
pass around the rootContainerAlias
codingkarthik Sep 6, 2024
5f6264e
rename visitNestedField1 to visitNestedField
codingkarthik Sep 6, 2024
1f6b8f7
refactor visitNestedField
codingkarthik Sep 6, 2024
efd0806
change the file structure
codingkarthik Sep 6, 2024
9b31b3e
fix the syntax of the query
codingkarthik Sep 9, 2024
dbe76b3
remove redundant function
codingkarthik Sep 9, 2024
34bdf47
minor no-op refactors
codingkarthik Sep 9, 2024
a706237
fix tests
codingkarthik Sep 9, 2024
7711acb
Merge branch 'main' into kc/nested-filtering-and-sorting
codingkarthik Sep 11, 2024
7c9f94a
add sql generation tests
codingkarthik Sep 11, 2024
db3d426
Merge branch 'main' into kc/nested-filtering-and-sorting
codingkarthik Sep 11, 2024
ef68c9a
figure out where the bug is
codingkarthik Sep 11, 2024
43d8f7d
one more attempt at debugging
codingkarthik Sep 11, 2024
d283049
add debug statement
codingkarthik Sep 11, 2024
02cc504
revert back the cli changes
codingkarthik Sep 11, 2024
fd33f92
fix the imports
codingkarthik Sep 11, 2024
3ce3dda
fix import 1
codingkarthik Sep 11, 2024
a5abf6d
add nested array object field filtering test case
codingkarthik Sep 12, 2024
add37b6
modify the failing tests according to the new data
codingkarthik Sep 12, 2024
bd6cc41
add nested filtering tests
codingkarthik Sep 12, 2024
2605c7e
Nested filtering
codingkarthik Aug 26, 2024
7004491
don't run tests on the azure cosmos emulator
codingkarthik Sep 12, 2024
0d66144
comment out the setting up of azure cosmos emulator
codingkarthik Sep 12, 2024
b1c968f
use the correct env values
codingkarthik Sep 12, 2024
a152da2
rever the changes in script folder
codingkarthik Sep 12, 2024
cd34378
remove the tests
codingkarthik Sep 12, 2024
c17346c
minor refactor
codingkarthik Sep 12, 2024
cab6f51
remove more tests
codingkarthik Sep 12, 2024
5b6f0be
remove even more tests
codingkarthik Sep 12, 2024
4b7ce3d
fix deep nested filtering bug
codingkarthik Sep 17, 2024
5f8e827
refactor visitNestedField
codingkarthik Sep 18, 2024
5478d2a
Merge branch 'main' into kc/nested-filtering-and-sorting
codingkarthik Sep 18, 2024
a372479
fix bug
codingkarthik Sep 19, 2024
d29485e
minor no-op refactor
codingkarthik Sep 19, 2024
cf8be21
add comment on getScalarType
codingkarthik Sep 23, 2024
e318e2c
minor refactor
codingkarthik Sep 23, 2024
43bb2ee
incorporate review comments
codingkarthik Sep 23, 2024
b7ba0f7
follow TS convention
codingkarthik Sep 23, 2024
d951a2b
Merge branch 'kc/nested-filtering-and-sorting' into kc/nested-filteri…
codingkarthik Sep 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,27 +13,27 @@ jobs:
with:
path: cosmos

- name: Set up Docker
uses: docker-practice/actions-setup-docker@master

- name: Pull and run Azure Cosmos DB Emulator
run: |
docker pull mcr.microsoft.com/cosmosdb/linux/azure-cosmos-emulator
docker run -d --name=cosmos-emulator -p 8081:8081 -p 10251:10251 -p 10252:10252 -p 10253:10253 -p 10254:10254 \
-e AZURE_COSMOS_EMULATOR_PARTITION_COUNT=10 \
-e AZURE_COSMOS_EMULATOR_ENABLE_DATA_PERSISTENCE=false \
mcr.microsoft.com/cosmosdb/linux/azure-cosmos-emulator

- name: Wait for Cosmos DB Emulator to be ready
run: |
timeout 300 bash -c 'until curl -ks https://localhost:8081/_explorer/emulator.pem > /dev/null; do sleep 5; done'
echo "Cosmos DB Emulator is ready"

- name: Download Cosmos DB Emulator certificate
run: |
curl -k https://localhost:8081/_explorer/emulator.pem > emulatorcert.crt
sudo cp emulatorcert.crt /usr/local/share/ca-certificates/
sudo update-ca-certificates
# - name: Set up Docker
# uses: docker-practice/actions-setup-docker@master

# - name: Pull and run Azure Cosmos DB Emulator
# run: |
# docker pull mcr.microsoft.com/cosmosdb/linux/azure-cosmos-emulator
# docker run -d --name=cosmos-emulator -p 8081:8081 -p 10251:10251 -p 10252:10252 -p 10253:10253 -p 10254:10254 \
# -e AZURE_COSMOS_EMULATOR_PARTITION_COUNT=10 \
# -e AZURE_COSMOS_EMULATOR_ENABLE_DATA_PERSISTENCE=false \
# mcr.microsoft.com/cosmosdb/linux/azure-cosmos-emulator

# - name: Wait for Cosmos DB Emulator to be ready
# run: |
# timeout 300 bash -c 'until curl -ks https://localhost:8081/_explorer/emulator.pem > /dev/null; do sleep 5; done'
# echo "Cosmos DB Emulator is ready"

# - name: Download Cosmos DB Emulator certificate
# run: |
# curl -k https://localhost:8081/_explorer/emulator.pem > emulatorcert.crt
# sudo cp emulatorcert.crt /usr/local/share/ca-certificates/
# sudo update-ca-certificates

- name: Build connector
run: |
Expand All @@ -55,9 +55,9 @@ jobs:

- name: Run tests
env:
AZURE_COSMOS_KEY: C2y6yDjf5/R+ob0N8A7Cgv30VRDJIWEHLM+4QDU5DE2nQ9nDuVTqobD4b8mGGyPMbIZnqyMsEcaGQy67XIw/Jw==
AZURE_COSMOS_ENDPOINT: https://localhost:8081
AZURE_COSMOS_DB_NAME: TestNobelLaureates
AZURE_COSMOS_KEY: ${{ secrets.AZURE_COSMOS_KEY }}
AZURE_COSMOS_ENDPOINT: ${{ secrets.AZURE_COSMOS_ENDPOINT }}
AZURE_COSMOS_DB_NAME: ${{ secrets.AZURE_COSMOS_DB_NAME }}
run: |
cd cosmos
npm run ndc-test -- --setup-emulator-data
npm run ndc-test
Loading
Loading