Add new a hyper parameter to enable or disable the avoidance in the last section #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, the maintainers of OpenPlanner.
As discussed in hatem-darweesh/autoware.ai.openplanner#9, replan is not triggered if the current rollouts reach the goal. Thus some collision will happen while there are obstacles between ego and goal. In some scenarios(such as bus stop), as you mentioned, this is a reasonable design choice. We enable and disable avoidance manually in the last section based on the hyperparameter, as suggested by your opinion. This approach provides convenience for users to adapt to various driving scenarios. Regarding the use of this hyper-parameter, we have already made the corresponding submission hatem-darweesh/common#18.
We are eagerly awaiting your feedback and response.