Block rollouts that cut through of drivable areas #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, maintainers of OpenPlanner.
Related to hatem-darweesh/common#19. These two PR both aim to solve the same problem of blocking undrivable rollouts. However, to judge if a waypoint is inside drivable areas, the op_trajectory_evaluator should be able to access the map, which is supported by this PR.
And it also solves a minor problem of the mismatch of rollouts number, as described here: https://answers.ros.org/question/397945/openplanner-25-failed-to-achieve-lane-change-with-errors-in-op_trajectory_evaluator/