Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): add missing critical to typings #271

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

BBosman
Copy link

@BBosman BBosman commented Jun 17, 2024

Add the missing iOS specificcritical to the TypeScript typings

Description

According to the API docs and the code a critical property is supported on iOS, but it is missing in the TypeScript typings. The PR adds it.

Related Issue

(#270)

Motivation and Context

Fixes TS compilation issues when using "critical" notifications on iOS.

How Has This Been Tested?

Used the updated typings in my own test project

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@erisu erisu merged commit 3ae7226 into havesource:master Aug 28, 2024
4 checks passed
@erisu erisu added this to the 5.0.0 milestone Nov 13, 2024
@erisu erisu added the ios Related to the iOS platform label Nov 13, 2024
Copy link

github-actions bot commented Dec 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ios Related to the iOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants