-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump @types/node from 18.18.6 to 20.8.9 #164
Conversation
da2e6c5
to
dac1b04
Compare
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.18.6 to 20.8.9. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dac1b04
to
2d25ffc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we are targetting node 16 and 18, it would seems unnecessary to upgrade to such a new major version. The result of initiating this change is an incompatibility in the parameters of window.fetch
that is overridden in osoauth-service.ts:
src/openshift/osoauth-service.ts(99,5): error TS2322: Type '(input: RequestInfo | URL, init?: RequestInit) => Promise<Response>' is not assignable to type '((input: URL | RequestInfo, init?: RequestInit | undefined) => Promise<Response>) & { (input: URL | RequestInfo, init?: RequestInit | undefined): Promise<...>; (input: RequestInfo, init?: RequestInit | undefined): Promise<...>; }'.
Type '(input: RequestInfo | URL, init?: RequestInit) => Promise<Response>' is not assignable to type '{ (input: URL | RequestInfo, init?: RequestInit | undefined): Promise<Response>; (input: RequestInfo, init?: RequestInit | undefined): Promise<...>; }'.
Types of parameters 'input' and 'input' are incompatible.
Type 'RequestInfo' is not assignable to type 'URL | RequestInfo'.
Type 'Request' is not assignable to type 'URL | RequestInfo'.
Property 'referrer' is missing in type 'import("/home/phantomjinx/programming/openshift/hawtio-online/node_modules/@types/node/node_modules/undici-types/fetch").Request' but required in type 'Request'.
@dependabot ignore this major version |
Sorry, the command you entered is not valid for this pull request. Please check the syntax and try again. Valid commands: |
OK, I won't notify you about version 20.x.x again, unless you re-open this PR. |
Bumps @types/node from 18.18.6 to 20.8.9.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)