[Style] Addition of the support of background-image-repeat #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still not sure its right im afraid... in your PR there is code being added for "drawRoundedRect", this was removed and your PR is re-adding it, which makes me cautious about what else it might be re-adding. If i were you it might make sense to close this PR, and make sure you have the most up to date version of haxeui-heaps (which presumably you dont currently), and then "redo" your changes. PITA for sure though... :/ |
|
Ah ! I made a bad merge, at some point. Then, I didn't check closely enough. Since it was after my new function, I missed it being an entirely other function ^^' |
|
I've fixed the merging to make sure I didn't erase some new stuff, it should be alright, now :D |
|
Great, thanks for this! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again ! :D
I thought I could delete the branch and add another to the pull request bu it turns out I can't, so i recreated the PR #40 (linked to issue #39) :P
Sorry, I'm still struggling with Git and Github :(