Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent mvn arguments #101

Closed

Conversation

JackPGreen
Copy link
Contributor

@JackPGreen JackPGreen commented Aug 13, 2024

Use the same options - e.g. --no-transfer-progress - for all commands.

Specifically - avoid filling the logs with Downloaded from central entries.

Use the same options - e.g. `--no-transfer-progress` - for all commands.
@JackPGreen JackPGreen requested a review from kwart August 13, 2024 09:23
@JackPGreen JackPGreen self-assigned this Aug 13, 2024
@JackPGreen JackPGreen marked this pull request as ready for review August 13, 2024 09:23
@JackPGreen
Copy link
Contributor Author

@kwart are you able to take a look at this, please?

Copy link
Contributor

@kwart kwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the PR builder run, it doesn't seem to be working properly (neither the batch-mode, nor the no-transfer-progress):

Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/shared/maven-script-interpreter/1.6/maven-script-interpreter-1.6.pom (4.5 kB at 499 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/groovy/groovy/4.0.21/groovy-4.0.21.pom
Progress (1): 4.1/24 kB
Progress (1): 8.2/24 kB
Progress (1): 12/24 kB 
Progress (1): 16/24 kB
Progress (1): 20/24 kB
Progress (1): 24 kB   

@JackPGreen
Copy link
Contributor Author

MAVEN_ARGS requires Maven 3.9, but the GitHub runners bundle 3.8.

@JackPGreen JackPGreen closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants