Added test for transactional JDBC sink #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gurbuzali
approved these changes
Apr 6, 2020
|
|
||
| @Override | ||
| public void init(JetInstance client) throws Exception { | ||
| connectionUrl = System.getProperty("connectionUrl", DEFAULT_DATABASE_URL) |
There was a problem hiding this comment.
property(String, String) method from AbstractSoakTest can be used here
|
|
||
| Pipeline pipeline = Pipeline.create(); | ||
|
|
||
| StreamSource<Integer> source = SourceBuilder |
There was a problem hiding this comment.
we use this source for other tests too, time to move it to a central place I guess. can be done as a separate PR
| private long counter; | ||
| private final PriorityQueue<Integer> verificationQueue = new PriorityQueue<>(); | ||
|
|
||
| public JdbcSinkVerifier(String name, ILogger logger, String connectionUrl) { |
There was a problem hiding this comment.
I also see some similarities between JmsSinkVerifier, GeneratedFilesVerifier and JdbcSinkVerifier. some of the logic can be centralized
olukas
force-pushed
the
snapshot-jdbc-sink-final
branch
from
5ff8c63
to
3c162aa
Compare
|
Thanks for review. I created #79 to track review comments related to logic centralization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.