Added the new on_cancel callback to ReliableMessageListener [API-2195] #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srknzl
reviewed
Jan 3, 2024
srknzl
reviewed
Jan 3, 2024
tests/integration/backward_compatible/proxy/reliable_topic_test.py
Outdated
Show resolved
Hide resolved
srknzl
reviewed
Jan 3, 2024
| def on_cancel(self): | ||
| print("Listener function on_cancel is called") | ||
|
|
||
| Durable Subscription |
There was a problem hiding this comment.
Btw, I think it might make sense to move these detailed information to the ReliableMessageListener's documentation (docstring comment) and give a link to it here.
…sageListener is cancelled for any reason. Added the documentation, tests and code sample update.
srknzl
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the new on_cancel callback which is called when the ReliableMessageListener is cancelled for any reason.
Added the documentation, tests and code sample update.